setcookie: Add note regarding SameSite=None and disabled Secure behavior #4916
+132
−139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested changes
Nov 4, 2025
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Indeed I have some markup notes, the wrapping para is very much unnecessary and please use <simpara> and fix the above note at the same time :)
Contributor
Author
|
In this case fixing this instance would have created an inconsistency with the markup across rest of this file, so I've reviewed the whole file to make it consistent. |
Girgias
requested changes
Dec 9, 2025
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Sorry for the delay, but going throught the file just brings to light more issues :/
Comment on lines
+86
to
+89
| You may notice the <parameter>expires_or_options</parameter> parameter takes on a | ||
| Unix timestamp, as opposed to the date format <literal>Wdy, DD-Mon-YYYY | ||
| HH:MM:SS GMT</literal>, this is because PHP does this conversion | ||
| internally. |
Member
There was a problem hiding this comment.
While at it could you rewrite this to get rid of the personalization (i.e. using "you") in accordance with the manual style guide.
| </note> | ||
| <note> | ||
| <simpara> | ||
| If <literal>samesite</literal> is <literal>None</literal> then |
Member
There was a problem hiding this comment.
Maybe as it is a string?
Suggested change
| If <literal>samesite</literal> is <literal>None</literal> then | |
| If <literal>samesite</literal> is <literal>"None"</literal> then |
Comment on lines
-251
to
+260
| <para> | ||
| </programlisting> | ||
| </example> | ||
| <simpara> | ||
| Note that the value portion of the cookie will automatically be | ||
| urlencoded when you send the cookie, and when it is received, it | ||
| is automatically decoded and assigned to a variable by the same | ||
| name as the cookie name. If you don't want this, you can use | ||
| <function>setrawcookie</function> instead. To see | ||
| the contents of our test cookie in a script, simply use one of the | ||
| following examples: | ||
| </para> | ||
| <para> | ||
| <informalexample> | ||
| <programlisting role="php"> | ||
| <
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4873