Sync wsdl-tools console version & add release Makefile#38
Merged
Conversation
The console application hardcoded its version (1.0.0), which drifted from the released git tags so `./bin/wsdl` printed a stale version. - Extract the version into a `APP_VERSION` constant set to 1.21.0 (the latest release), so it is both discoverable and rewritable. - Add a Makefile `tag` target (modelled on phpro/grumphp) that rewrites APP_VERSION, lints, commits and creates a signed tag without the `v` prefix, keeping the constant and the tag in sync by construction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
wsdl-toolsconsole application hardcoded its version (1.0.0), which drifted from the released git tags, so./bin/wsdlprinted a stale version.Changes
AppFactory::APP_VERSIONconstant set to1.21.0(the latest release), so it is both discoverable and rewritable.Makefiletagtarget (modelled on phpro/grumphp) that rewritesAPP_VERSION, lints the file, commits and creates a signed tag without thevprefix — matching the current tag convention — so the constant and the git tag stay in sync by construction: