FlatteningLoader|Throw UnloadableWsdlException when loader returns empty content#37
Merged
veewee merged 1 commit intoMay 28, 2026
Conversation
YasserB94
changed the title
YasserB94
force-pushed
the
feat/flattening-loader-empty-content-exception
branch
from
4890d90 to
90abfa2
Compare
YasserB94
force-pushed
the
feat/flattening-loader-empty-content-exception
branch
from
90abfa2 to
289721d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a WSDL loader returns empty content, the
FlatteningLoaderwould throw anAssertExceptionmaking it hard to understand what went wrong.This PR replaces it with a
UnloadableWsdlExceptionmaking the error clearerChanges
UnloadableWsdlException::noContentAt()named constructornon_empty_string()->assert()with an explicit empty check inFlatteningLoader