Upgrade to veewee/xml v4 with PHP 8.4+ Dom\ namespace#55
Merged
veewee merged 1 commit intophp-soap:mainfrom Mar 27, 2026
Merged
Upgrade to veewee/xml v4 with PHP 8.4+ Dom\ namespace#55veewee merged 1 commit intophp-soap:mainfrom
veewee merged 1 commit intophp-soap:mainfrom
Conversation
veewee
force-pushed
the
feature/upgrade-veewee-xml-v4
branch
2 times, most recently
from
7794992 to
1ddc538
Compare
- Bump minimum PHP to 8.4 - Upgrade veewee/xml from ^3.6 to ^4.10 - Bump php-soap/engine to ^2.20, php-soap/wsdl to ^1.19, php-soap/xml to ^1.10 - Replace monorepo PSL with standalone packages (^6.1) - Migrate all DOM types: DOMElement -> Dom\Element, DOMNameSpaceNode -> Dom\NamespaceInfo - Switch locate_by_tag_name to locate_by_namespaced_tag_name (getElementsByTagName now matches qualified names in spec-compliant DOM) - Handle getAttribute() returning null instead of '' for missing attributes - Use toUnsafeLegacyDocument() in SchemaParser for goetas-webservices/xsd-reader compatibility (still uses DOMElement) - Add DOM stubs and phpVersion to psalm.xml - Remove PHP 8.3 from CI matrices
veewee
force-pushed
the
feature/upgrade-veewee-xml-v4
branch
from
1ddc538 to
9a21bc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dom\namespace (DOMElement->Dom\Element,DOMNameSpaceNode->Dom\NamespaceInfo)locate_by_tag_namewithlocate_by_namespaced_tag_name(spec-compliant DOM'sgetElementsByTagNamematches qualified names, not local names)getAttribute()returningnullinstead of''for missing attributestoUnsafeLegacyDocument()from veewee/xml 4.10 for xsd-reader interopTest plan
docphpro/php84Docker (Ubuntu 24.04, libxml 2.9.14)