Skip to content

Localization of dates in date-helpers #94

Closed
Enough7 wants to merge 9 commits intophoinixi:mainfrom
Enough7:main
Closed

Localization of dates in date-helpers #94
Enough7 wants to merge 9 commits intophoinixi:mainfrom
Enough7:main

Conversation

@Enough7
Copy link
Copy Markdown
Contributor

@Enough7 Enough7 commented Jan 13, 2025

Hi,

I added localization of dates in date-helpers and replaced moment package with JavaScript Date API.
Also wrote some tests.

Best reagards,
Enough7

@phoinixi
Copy link
Copy Markdown
Owner

Hey @Enough7 you have some conflicts on this PR

@Enough7
Copy link
Copy Markdown
Contributor Author

Enough7 commented Feb 18, 2025

Hey @phoinixi,

sorry I read the notification but forgot to answer.
Could you clarify what you mean? I do not get it because it says No conflicts with base branch.

@Enough7
Copy link
Copy Markdown
Contributor Author

Enough7 commented May 26, 2025

@phoinixi ?

@phoinixi
Copy link
Copy Markdown
Owner

image

@Enough7
Copy link
Copy Markdown
Contributor Author

Enough7 commented May 26, 2025

@phoinixi Is this some kind of third party program? GitHub in its WebGui says there are no conflicts.
Screenshot_20250526_210519_Firefox

@phoinixi
Copy link
Copy Markdown
Owner

maybe you can try to rebase main into your branch and you will see the conflicts

ermis-cy pushed a commit to ermis-cy/jsonresume-theme-stackoverflow that referenced this pull request Feb 15, 2026
- Replace moment.js with native JavaScript Date API for date formatting
- Add i18next and handlebars-i18next for section title localization
- Support English and German translations out of the box
- Add changeLanguage() API to switch locale before rendering
- Extract HTMLValidate test helper to separate module
- Add date helper tests for English and German locales
- Fix volunteer.hbs missing closing tag in section title

Supersedes phoinixi#94 (by @Enough7), rebased onto latest main with
conflict resolution.
@ermis-cy
Copy link
Copy Markdown
Collaborator

Thanks for the contribution! I've rebased your changes onto the latest main and opened #103 to supersede this PR (resolves merge conflicts).

ermis-cy added a commit that referenced this pull request Feb 15, 2026
- Replace moment.js with native JavaScript Date API for date formatting
- Add i18next and handlebars-i18next for section title localization
- Support English and German translations out of the box
- Add changeLanguage() API to switch locale before rendering
- Extract HTMLValidate test helper to separate module
- Add date helper tests for English and German locales
- Fix volunteer.hbs missing closing tag in section title

Supersedes #94 (by @Enough7), rebased onto latest main with
conflict resolution.

Co-authored-by: Ermis <thenest@Thes-Mac-mini.local>
@ermis-cy ermis-cy closed this Feb 15, 2026
ermis-cy added a commit that referenced this pull request Feb 15, 2026
- Replace moment.js with native JavaScript Date API for date formatting
- Add i18next and handlebars-i18next for section title localization
- Support English and German translations out of the box
- Add changeLanguage() API to switch locale before rendering
- Extract HTMLValidate test helper to separate module
- Add date helper tests for English and German locales
- Fix volunteer.hbs missing closing tag in section title

Supersedes #94 (by @Enough7), rebased onto latest main with
conflict resolution.

Co-authored-by: Ermis <thenest@Thes-Mac-mini.local>
ermis-cy added a commit to ermis-cy/jsonresume-theme-stackoverflow that referenced this pull request Feb 15, 2026
- Replace moment.js with native JavaScript Date API for date formatting
- Add i18next and handlebars-i18next for section title localization
- Support English and German translations out of the box
- Add changeLanguage() API to switch locale before rendering
- Extract HTMLValidate test helper to separate module
- Add date helper tests for English and German locales
- Fix volunteer.hbs missing closing tag in section title

Supersedes phoinixi#94 (by @Enough7), rebased onto latest main with
conflict resolution.
github-actions Bot pushed a commit that referenced this pull request Feb 15, 2026
# [2.2.0](v2.1.0...v2.2.0) (2026-02-15)

### Bug Fixes

* add spacing between profile links ([3f2f897](3f2f897))
* add URL support for education and volunteer sections ([#105](#105)) ([d3c8564](d3c8564)), closes [#99](#99)
* dark mode uses warm zinc palette, fix demo landing iframe and light/dark rendering ([2f06a14](2f06a14))
* make company name clickable with url field (Fixes [#98](#98)) ([c12fed9](c12fed9))
* pass language option through render() for i18n support ([754029b](754029b))
* rebuild dist with normalizeLevel in bundle ([b683236](b683236))
* resolve HTML validation errors (Fixes [#92](#92)) ([72fd583](72fd583))
* update repository URL and screenshot paths in README ([cca232d](cca232d))

### Features

* **a11y:** add accessibility improvements ([8d91ace](8d91ace)), closes [#resume](https://github.com/phoinixi/jsonresume-theme-stackoverflow/issues/resume) [#2c5777](https://github.com/phoinixi/jsonresume-theme-stackoverflow/issues/2c5777) [#dfeaf1](https://github.com/phoinixi/jsonresume-theme-stackoverflow/issues/dfeaf1)
* add 12 language translations for i18n ([020c207](020c207))
* add dark mode support via prefers-color-scheme ([b3bed16](b3bed16))
* add GitHub Pages demo with light/dark preview and landing page ([ef337b4](ef337b4))
* add i18n localization support for dates and section titles ([#103](#103)) ([52355bd](52355bd)), closes [#94](#94)
* add override.css stylesheet to resume template ([#104](#104)) ([17892c5](17892c5)), closes [#97](#97)
* add theme customization via resume.json meta field ([249b95f](249b95f))
* **css:** add mobile responsive styles ([e2db48e](e2db48e))
* migrate from Handlebars to Svelte SSR ([4eb6386](4eb6386))
* normalize skill/language levels to support synonyms and i18n ([dca1e65](dca1e65))
github-actions Bot pushed a commit that referenced this pull request Feb 15, 2026
# [3.0.0](v2.1.0...v3.0.0) (2026-02-15)

* feat!: v3.0.0 — Svelte SSR, dark mode, i18n, accessibility ([31c4f70](31c4f70))

### Bug Fixes

* add spacing between profile links ([3f2f897](3f2f897))
* add URL support for education and volunteer sections ([#105](#105)) ([d3c8564](d3c8564)), closes [#99](#99)
* dark mode uses warm zinc palette, fix demo landing iframe and light/dark rendering ([2f06a14](2f06a14))
* make company name clickable with url field (Fixes [#98](#98)) ([c12fed9](c12fed9))
* pass language option through render() for i18n support ([754029b](754029b))
* rebuild dist with normalizeLevel in bundle ([b683236](b683236))
* resolve HTML validation errors (Fixes [#92](#92)) ([72fd583](72fd583))
* update repository URL and screenshot paths in README ([cca232d](cca232d))

### Features

* **a11y:** add accessibility improvements ([8d91ace](8d91ace)), closes [#resume](https://github.com/phoinixi/jsonresume-theme-stackoverflow/issues/resume) [#2c5777](https://github.com/phoinixi/jsonresume-theme-stackoverflow/issues/2c5777) [#dfeaf1](https://github.com/phoinixi/jsonresume-theme-stackoverflow/issues/dfeaf1)
* add 12 language translations for i18n ([020c207](020c207))
* add dark mode support via prefers-color-scheme ([b3bed16](b3bed16))
* add GitHub Pages demo with light/dark preview and landing page ([ef337b4](ef337b4))
* add i18n localization support for dates and section titles ([#103](#103)) ([52355bd](52355bd)), closes [#94](#94)
* add override.css stylesheet to resume template ([#104](#104)) ([17892c5](17892c5)), closes [#97](#97)
* add theme customization via resume.json meta field ([249b95f](249b95f))
* **css:** add mobile responsive styles ([e2db48e](e2db48e))
* migrate from Handlebars to Svelte SSR ([4eb6386](4eb6386))
* normalize skill/language levels to support synonyms and i18n ([dca1e65](dca1e65))

### BREAKING CHANGES

* Complete rewrite from Handlebars to Svelte SSR.
- Handlebars templates replaced with Svelte 5 components
- render() now returns full HTML document (not a fragment)
- Node.js 18+ required
- New features: dark mode, 12 languages, theme customization, smart skill levels, accessibility, responsive design
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants