Skip to content

Allow structs as select option values #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Sep 21, 2025
Merged

Allow structs as select option values #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/phoenix_html/form.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,8 @@ defmodule Phoenix.HTML.Form do
end

defp option(group_label, group_values, extra, value)
when is_list(group_values) or is_map(group_values) do
when is_list(group_values) or
(is_map(group_values) and not is_map_key(group_values, :__struct__)) do
section_options = escaped_options_for_select(group_values, value, extra)
option_tag("optgroup", [label: group_label], {:safe, section_options})
end
Expand Down
13 changes: 13 additions & 0 deletions test/phoenix_html/form_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,19 @@ defmodule Phoenix.HTML.FormTest do
~s(<option value="value">Label</option>) <>
~s(<hr/>) <>
~s(<option value="new">New</option>)

assert options_for_select(
[
{"Open", ~U[2025-01-01 06:30:00.000000Z]},
{"Close", ~U[2025-01-01 18:30:00.000000Z]}
],
[
~U[2025-01-01 06:30:00.000000Z]
]
)
|> safe_to_string() ==
~s(<option selected value="2025-01-01T06:30:00.000000Z">Open</option>) <>
~s(<option value="2025-01-01T18:30:00.000000Z">Close</option>)
end

test "with custom option tag" do
Expand Down