Raise on pipe_through if route or scope previously defined in scope#6720
Open
wondr-wclabs wants to merge 2 commits into
Open
Raise on pipe_through if route or scope previously defined in scope#6720wondr-wclabs wants to merge 2 commits into
wondr-wclabs wants to merge 2 commits into
Conversation
Member
|
This would be a breaking chance, so it should warm about being deprecated. Also, it’s only about routes, not scopes. |
Member
|
Also, remove unrelated commits please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6139. This ensures
pipe_throughmust be placed before any routes or sub-scopes within a scope block, preventing confusing behavior where a pipeline is only applied to routes declared after it in the same scope.