Ensure layout version selection sets element size for exclusively unscaled images#692
Ensure layout version selection sets element size for exclusively unscaled images#692liamwhite wants to merge 1 commit into
Conversation
|
@uis246 for the record, the change you made breaks if the image's partscaled height exceeds 80vh |
|
How do I reproduce it? |
|
Upload an image like https://derpibooru.org/images/3800399 and then view it scaled or partscaled with a 1600x1920 viewport, and it'll be squished |
|
Firefox devtools emulate "a phone" with 1600x1920 screen with DPR=1 and touch off. for (i of document.getElementsByClassName('image-target')) {pic = i.children[0].children[0]; ds = i.dataset; pic.height = ds.height; pic.width = ds.width;}See nothing happen.
Maybe scaled? Only scaled image mentions 80vh. |
|
Forgot how dimensions work - meant 1920x1600 |
Scaled and unscaled have same size. What will happen if you add img {
height: auto;
width: auto;
}to styles? Will problem persist? |
|
Apparently in addition to swapping dimensions I also do not know how to count - it should have been 1920x964 |
Reproduced. |


Fixes visual regression from #652 for scaled/partscaled images that extend off the viewport