Open
Conversation
Signed-off-by: Alasjo <alexander@alasjo.se>
Signed-off-by: Alasjo <alexander@alasjo.se>
|
Why'd you use the "$str" variable? Shouldn't be "$string"? |
|
yes Jonathan, it's true. And the good function is: |
Changed from `$str` to `$string`
Author
|
I missed the typo of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed when testing PHP AES File Encryption in PHP 5.3.1 that the creation of key failed (because
hex2binwasn't introduced until PHP 5.4.0). In the readme of this project it states compatibility with PHP5 so I set out to fulfill that statement.I have added a function similar to the
bin_*functions in the library that checks ifhex2binexists, otherwise using an alternative approach withpackfrom the PHP.net comment section.Moreover, the
mb_substrfunction seems to treat length of NULL as zero. I have added a check forNULLlength and replace it with themb_strlenof the string.Tested and working in PHP 5.3.1.