Add basic theme support and switch config to hex colors.#17
Draft
simotek wants to merge 7 commits intophiler:masterfrom
Draft
Add basic theme support and switch config to hex colors.#17simotek wants to merge 7 commits intophiler:masterfrom
simotek wants to merge 7 commits intophiler:masterfrom
Conversation
This will hopefully make them easier to maintain in the long term. The main polycore config all the examples and tests have been updated although the test suite isn't rendering for me. For now the split is as follows, but open to changes and suggestions:
* widget_core * Widget * Rows * Columns * Filler * Frame
* widget_cpu
* Cpu
* CpuRound * CpuFrequencies
* widget_drive * Drive
* widget_gpu
* Gpu
* GpuTop
* widget_graph - This could have a better name * Bar * Graph * LED
* widget_memory
* MemoryBar
* MemoryGrid
* widget_network * Network
* widget_text
* Text
* StaticText * TextLine
Cairo requires 0.0->1.0 and this makes doing that much simpler
All "theme" elements have now been moved into a separate file and module, to make it easier to add new ones. At startup each config needs to load a theme module into the current_theme variable.
Rather then users having to manually convert there colors to cairo's non standard 0.0->1.0 rgb format users now specify colors as hex strings either with or without a leading hash. The same as the format used by conky. All the widgets now convert these colors internally to the cairo format.
Author
|
I marked this one as a draft because I'll need to rebase it at some point once some of the other changes are in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
current_themevariable so that its easy to add and swap between colors and fonts, we can also build up and add more style options later.I suspect that it will be best if I rebase this one after the other PR's are accepted.
I also made the following as a second different example that can be used for testing. But I figured there is no point in pushing it yet because it doesn't really have a matching conky config yet.
https://github.com/simotek/conky-bubbles/blob/dev/src/themes/dimensions.lua