Skip to content

fix issues on elastic driver#1488

Merged
phenobarbital merged 1 commit intomasterfrom
or_conditions
Feb 21, 2026
Merged

fix issues on elastic driver#1488
phenobarbital merged 1 commit intomasterfrom
or_conditions

Conversation

@phenobarbital
Copy link
Copy Markdown
Owner

@phenobarbital phenobarbital commented Feb 21, 2026

  • Fix issues on elasticsearch driver
  • added RedPanda (aiokafka) driver

Summary by Sourcery

Bump library version and streamline example PostgreSQL streaming script by removing the datatable-based example.

Enhancements:

  • Remove the datatable streaming example from the PostgreSQL test script to focus on supported output backends.

Chores:

  • Update the package version to 2.14.1.

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Feb 21, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the PostgreSQL streaming example to drop the datatable dependency, bumps the asyncdb package version, and includes changes to the Elasticsearch driver and a new RedPanda (aiokafka) driver as described in the PR (details not fully visible in the diff).

Sequence diagram for producing a message via new RedPanda driver

sequenceDiagram
    actor Application
    participant RedPandaDriver
    participant AiokafkaProducer
    participant RedPandaCluster

    Application->>RedPandaDriver: connect(dsn)
    RedPandaDriver->>AiokafkaProducer: start()
    AiokafkaProducer-->>RedPandaDriver: producer_started
    RedPandaDriver-->>Application: connected

    Application->>RedPandaDriver: produce(topic, key, value)
    RedPandaDriver->>AiokafkaProducer: send(topic, key, value)
    AiokafkaProducer->>RedPandaCluster: append message to log
    RedPandaCluster-->>AiokafkaProducer: ack
    AiokafkaProducer-->>RedPandaDriver: send result
    RedPandaDriver-->>Application: result

    Application->>RedPandaDriver: close()
    RedPandaDriver->>AiokafkaProducer: stop()
    AiokafkaProducer-->>RedPandaDriver: stopped
    RedPandaDriver-->>Application: closed
Loading

Class diagram for updated drivers including Elasticsearch and new RedPanda driver

classDiagram
    class BaseDriver {
        +str dsn
        +bool connected
        +connect()
        +close()
    }

    class ElasticDriver {
        +str hosts
        +str index
        +connect()
        +close()
        +search(query)
        +index_document(document_id, document)
        +update_document(document_id, document)
        +delete_document(document_id)
    }

    class RedPandaDriver {
        +str bootstrap_servers
        +str client_id
        +bool producer_started
        +bool consumer_started
        +connect()
        +close()
        +produce(topic, key, value)
        +consume(topic, group_id)
        +commit()
    }

    BaseDriver <|-- ElasticDriver
    BaseDriver <|-- RedPandaDriver
Loading

File-Level Changes

Change Details Files
Remove datatable streaming example and dependency from the PostgreSQL streaming example script.
  • Delete datatable import and its parser import
  • Remove the test_datatable async function that streamed results to a datatable.Frame and converted to pandas
  • Stop referencing test_datatable in the main routine
examples/test_pg_stream.py
Bump library version for this release.
  • Increment asyncdb version from 2.14.0 to 2.14.1
asyncdb/version.py
Adjust Elasticsearch driver implementation and add a new RedPanda (aiokafka) driver as per PR description (exact code changes not visible).
  • Modify Elasticsearch driver behavior or bug fixes in elastic driver module
  • Introduce or update RedPanda driver built on aiokafka for Kafka/RedPanda connectivity
asyncdb/drivers/elastic.py
asyncdb/drivers/redpanda.py
asyncdb/drivers/aiokafka.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@phenobarbital phenobarbital merged commit e178f13 into master Feb 21, 2026
1 of 2 checks passed
@phenobarbital phenobarbital deleted the or_conditions branch February 21, 2026 23:56
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

phenobarbital added a commit that referenced this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant