Fix b2World_OverlapCapsule incorrect reference to center#23
Open
mikuso wants to merge 1 commit intophaserjs:mainfrom
Open
Fix b2World_OverlapCapsule incorrect reference to center#23mikuso wants to merge 1 commit intophaserjs:mainfrom
mikuso wants to merge 1 commit intophaserjs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick one-character fix to a broken function.
Explanation:
b2World_OverlapCapsulein world_c.js makes an invalid reference to a non-existentcenterproperty onb2Capsule.The
b2Capsulestructure containscenter1andcenter2properties, but nocenterproperty. (this is correct, per the original code)The original code for
b2World_OverlapCapsuleuses thecenter1property of the capsule instead.This PR corrects this reference in world_c.js and brings parity to the original source.