Skip to content

Conversation

@nimish-ks
Copy link
Member

Extended the existing secret referencing system to support cross-app secret referencing.

@rohan-chaturvedi
Copy link
Member

@nimish-ks When a reference cannot be resolved, this throws an exception:

"Error fetching secrets: Error: Failed to resolve reference ${LHC::staging.FOO}: Failed to resolve reference: Invalid environment name: staging"

This seems to diverge from the behavior of other SDKs, which leave the unresolved reference syntax in place. Lets keep the behavior consistent, but perhaps console.warn about the failed reference resolution

@nimish-ks
Copy link
Member Author

@nimish-ks When a reference cannot be resolved, this throws an exception:

"Error fetching secrets: Error: Failed to resolve reference ${LHC::staging.FOO}: Failed to resolve reference: Invalid environment name: staging"

This seems to diverge from the behavior of other SDKs, which leave the unresolved reference syntax in place. Lets keep the behavior consistent, but perhaps console.warn about the failed reference resolution

Good catch. Fixed. Please retest.

Copy link
Member

@rohan-chaturvedi rohan-chaturvedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimish-ks nimish-ks merged commit b3f2356 into main Apr 14, 2025
1 check passed
@nimish-ks nimish-ks deleted the feat--cross-app-secret-referencing branch April 14, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants