Skip to content

Added try catches to prevent app from crashing #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Antriadus wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added try catches to prevent app from crashing #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d00ce6e
Wrapped unregisterReceiver with try catch
KamilMrowiec Jan 24, 2022
61bba8b
Wrapped more code with try catch
KamilMrowiec Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions android/src/main/kotlin/dev/pharsh/sms_user_consent/SmsUserConsentPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,20 @@ class SmsUserConsentPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
}
SMS_CONSENT_REQUEST -> {// Obtain the phone number from the result
if (resultCode == Activity.RESULT_OK && data != null) {
channel
.invokeMethod("receivedSms", data.getStringExtra(SmsRetriever.EXTRA_SMS_MESSAGE))
mActivity.unregisterReceiver(smsVerificationReceiver)
try {
channel.invokeMethod("receivedSms", data.getStringExtra(SmsRetriever.EXTRA_SMS_MESSAGE))
mActivity.unregisterReceiver(smsVerificationReceiver)
} catch (e: Exception) {
// silent catch to avoid crash if receiver is not registered
}
} else {
// Consent denied. User can type OTC manually.
channel.invokeMethod("receivedSms", null)
mActivity.unregisterReceiver(smsVerificationReceiver)
try {
// Consent denied. User can type OTC manually.
channel.invokeMethod("receivedSms", null)
mActivity.unregisterReceiver(smsVerificationReceiver)
} catch (e: Exception) {
// silent catch to avoid crash if receiver is not registered
}
}
true
}
Expand Down