Skip to content

Fix: Implement = and hash#17

Merged
jordanmontt merged 5 commits intopharo-containers:masterfrom
HossamSaberr:master
Mar 23, 2026
Merged

Fix: Implement = and hash#17
jordanmontt merged 5 commits intopharo-containers:masterfrom
HossamSaberr:master

Conversation

@HossamSaberr
Copy link
Copy Markdown
Contributor

Fix #16.

Previously, CTQueue inherited Object's default identity comparison, meaning two queues with the exact same elements were not considered equal.

Changes made:

  • Implemented #= in CTQueue to compare species, size, and internal elements.
  • Implemented #hash in CTQueue using the standard collection hash multiplier.
  • Added testEquality to CTQueueTest to verify that identical queues evaluate to true and their hashes match.

All tests are Green now

image

@jordanmontt jordanmontt merged commit e453e5b into pharo-containers:master Mar 23, 2026
15 checks passed
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 23, 2026

Pull Request Test Coverage Report for Build 23444689315

Details

  • 17 of 17 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 96.757%

Totals Coverage Status
Change from base Build 21006753084: 0.3%
Covered Lines: 179
Relevant Lines: 185

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing equals and hash implementation

3 participants