Fix: structural integrity during copy#8
Merged
jordanmontt merged 1 commit intopharo-containers:mainfrom Mar 24, 2026
Merged
Conversation
Member
|
Great catch!!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical structural bug in the
copymethod that caused the copied tree to degrade into a right-skewed linked list.The Issue:
The previous implementation used
inOrderDo:to populate the new tree. BecauseinOrderDo:yields elements in strictly ascending order, inserting them sequentially into a new BST causes it to build a straight line of right-child nodes, ruining the O(log N) performance.The Fix:
Changed the traversal to
preOrderDo:. By extracting and inserting the root first, then the left and right subtrees, the copied tree perfectly reconstructs the original shape.Changes made:
CTBinarySearchTree >> copyto usepreOrderDo:.CTBinarySearchTreeTest >> testCopyPreservesStructureto assert that tree height and node placements remain identical after a copy operation.and all tests Green now :)
Closes #7