Create a new function to get HL plots from a PKNCAdata object#932
Merged
Create a new function to get HL plots from a PKNCAdata object#932
Conversation
2 tasks
js3110
reviewed
Jan 26, 2026
Collaborator
js3110
left a comment
There was a problem hiding this comment.
Looks good! Some nitpicks and a couple of comments/questions
Collaborator
Author
|
Tidyverse style will be ignored for this case (PKNCA), the rest of points will be addressed |
Collaborator
What do you mean by this? I am assuming you have plans to integrate this as a PKNCA function and that PKNCA doesn't use tidyverse? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #931
Description
get_halflife_plotsto generate Plotly-based half-life plots from PKNCA data, including fit lines, scatter points, and customizable annotations. Handles missing/excluded data robustly and supports grouping.get_halflife_plots_singleto encapsulate the logic for rendering a single plot, managing marker colors, shapes, and hover text for individual data points.test-get_halflife_plots.R) covering:Definition of Done
How to test
No need to open the App. Just check the code logic and the tests. Run the testing file with the example input. Feel free to try with any other PKNCAdata input (although this is just optional homework 😉 )
Contributor checklist
Notes to reviewer
Tidyverse style is not followed in this PR