feat(parsers): migrate from ethers to ox (#372)#373
Closed
srivtx wants to merge 1 commit intophantom:mainfrom
Closed
feat(parsers): migrate from ethers to ox (#372)#373srivtx wants to merge 1 commit intophantom:mainfrom
srivtx wants to merge 1 commit intophantom:mainfrom
Conversation
- Replace ethers.js with ox library for ~1000x faster RLP encoding - Use Address.from() instead of getAddress() for address checksumming - Use TransactionEnvelopeEip1559/Legacy for transaction serialization - Add explicit type detection for EIP-1559 vs Legacy transactions - Default chainId to 1 (mainnet) when not provided for EIP-1559 txs Closes phantom#372
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
|
Closing per #372 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #372
Summary & Motivation
This PR addresses issue #372 by migrating the
@phantom/parserspackage from ethers.js to ox for EVM transaction parsing.Why ox over ethers?
The public API remains unchanged - this is a purely internal implementation swap.
How I Tested These Changes
yarn test)yarn build)Did you add a changeset?
Not yet - I can add one if needed.
Did you update the README files?
No README updates needed - the public API is unchanged. This is an internal dependency swap only.