Skip to content

Fix duplicate access logs #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TomiBelan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix duplicate access logs #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/hypercorn/protocol/http_stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,12 +241,13 @@ async def app_send(self, message: ASGISendEvent | None) -> None:
raise UnexpectedMessageError(self.state, message["type"])

async def _send_closed(self) -> None:
await self.send(EndBody(stream_id=self.stream_id))
self.state = ASGIHTTPState.CLOSED
await self.send(EndBody(stream_id=self.stream_id))
await self.config.log.access(self.scope, self.response, time() - self.start_time)
await self.send(StreamClosed(stream_id=self.stream_id))

async def _send_error_response(self, status_code: int) -> None:
self.state = ASGIHTTPState.CLOSED
await self.send(
Response(
stream_id=self.stream_id,
Expand All @@ -255,7 +256,6 @@ async def _send_error_response(self, status_code: int) -> None:
)
)
await self.send(EndBody(stream_id=self.stream_id))
self.state = ASGIHTTPState.CLOSED
await self.config.log.access(
self.scope, {"status": status_code, "headers": []}, time() - self.start_time
)