Skip to content

Remove redundant same-shard check for cross-shard updates#1141

Open
sgrif wants to merge 1 commit into
mainfrom
sg-redundant-check
Open

Remove redundant same-shard check for cross-shard updates#1141
sgrif wants to merge 1 commit into
mainfrom
sg-redundant-check

Conversation

@sgrif

@sgrif sgrif commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

We don't need to check this in insert_row, we already checked if we're on the same shard in UpdateMulti::execute_internal before calling this

We don't need to check this in insert_row, we already checked if we're
on the same shard in UpdateMulti::execute_internal before calling this
@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../frontend/client/query_engine/multi_step/update.rs 83.33% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@sgrif sgrif requested a review from levkk July 5, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant