Skip to content

Replace Postgres-based delta apply approach with extension-only one #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mason-sharp merged 8 commits into from
Dec 30, 2025
Merged

Replace Postgres-based delta apply approach with extension-only one #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f62bc63
Introduce a delta_apply security label management.
danolivo Nov 24, 2025
18b21f5
Replicate SECURITY LABEL commands.
danolivo Nov 25, 2025
149c585
Use security labels to implement the delta_apply feature.
danolivo Nov 26, 2025
32ad9e9
Remove the core attribute options.
danolivo Nov 26, 2025
6c154a6
Let the security label-based delta apply feature be a first-class cit…
danolivo Nov 28, 2025
57c21f6
Disallow the delta apply feature on nullable columns.
danolivo Dec 2, 2025
6f25d27
Rebase onto current master
danolivo Dec 17, 2025
d7d2ba8
Rename delta_apply related variables.
danolivo Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,6 @@ PG_CPPFLAGS += -I$(libpq_srcdir) \
-I$(realpath src/compat/$(PGVER)) \
-Werror=implicit-function-declaration
SHLIB_LINK += $(libpq) $(filter -lintl, $(LIBS))
ifdef NO_LOG_OLD_VALUE
PG_CPPFLAGS += -DNO_LOG_OLD_VALUE
endif

REGRESS := __placeholder__
EXTRA_CLEAN += $(control_path) spock_compat.bc
Expand Down
1 change: 1 addition & 0 deletions include/spock.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#define SPOCK_VERSION_NUM 60000

#define EXTENSION_NAME "spock"
#define SPOCK_SECLABEL_PROVIDER "spock"

#define REPLICATION_ORIGIN_ALL "all"

Expand Down
7 changes: 5 additions & 2 deletions include/spock_relcache.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,12 @@ typedef struct SpockRelation
Oid idxoid;
Relation rel;
int *attmap;
bool has_delta_columns;
Oid *delta_apply_functions;

/* Additional cache, only valid as long as relation mapping is. */
bool hasTriggers;

Oid *delta_apply_functions;
bool has_delta_columns;
} SpockRelation;

extern void spock_relation_cache_update(uint32 remoteid,
Expand All @@ -68,6 +69,8 @@ extern void spock_relation_cache_reset(void);

extern Oid spock_lookup_delta_function(char *fname, Oid typeoid);

extern Oid get_replication_identity(Relation rel);

struct SpockTupleData;

#endif /* SPOCK_RELCACHE_H */
194 changes: 0 additions & 194 deletions patches/15/pg15-015-attoptions.diff
View file
Open in desktop

This file was deleted.

Loading