Skip to content

Conversation

@tsivaprasad
Copy link
Contributor

@tsivaprasad tsivaprasad commented Dec 3, 2025

Summary

This PR adds detailed documentation and verified procedures for changing a Control Plane host’s etcd mode between server and client after initialization.

Changes

  • Steps to safely promote a client → server
  • Steps to safely demote a server → client
  • Required environment variable changes
  • Performed full manual verification in a dev cluster

Testing

Manually validated:

  • Promoting a client host to server mode
  • Demoting a server host to client mode

Verified etcd cluster state with:

  • etcdctl member list -w table
  • etcdctl endpoint health

Checklist

  • Documentation updated

PLAT-315

@tsivaprasad tsivaprasad requested a review from Copilot December 3, 2025 17:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive documentation for reconfiguring etcd mode on Control Plane hosts, enabling operators to safely change hosts between server and client modes after initial deployment. The documentation includes detailed procedures, troubleshooting guidance, and best practices based on manual testing in a development environment.

Key Changes

  • Added complete step-by-step procedures for promoting clients to servers and demoting servers to clients
  • Documented environment variable configuration requirements and container restart workflows
  • Fixed a bug in rbac.go to ensure EtcdMode is persisted when writing host credentials

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
docs/using/etcd-reconfiguration.md New documentation file covering etcd mode reconfiguration procedures, prerequisites, troubleshooting, and best practices
server/internal/etcd/rbac.go Added missing EtcdMode assignment to ensure mode is preserved in generated config

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tsivaprasad tsivaprasad marked this pull request as draft December 4, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants