add FS.scheme property#338
Closed
yhrkw wants to merge 1 commit into
Closed
Conversation
kuenishi
requested changes
Aug 13, 2024
Member
kuenishi
left a comment
kuenishi
left a comment
There was a problem hiding this comment.
The overall looks good, but I want a bit doc to clarify what the property is for.
| self.pid = os.getpid() | ||
| if scheme: | ||
| self._scheme = str(scheme) | ||
|
|
Member
There was a problem hiding this comment.
I'd like you to add a few sentences of document here to clarify this variable stores the name of custom scheme or actual implementation scheme (e.g. s3, data, or hdfs). Reading the code told me either can be here. The former if custom scheme defined, and the latter if it's not defined.
Merged
Contributor
|
Duplicate with #377 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #331 (comment)