Implement GIS001 analyzer to detect inefficient Geometry.Union calls in loops#3
Draft
Implement GIS001 analyzer to detect inefficient Geometry.Union calls in loops#3
Conversation
Co-authored-by: petrovicz <10641425+petrovicz@users.noreply.github.com>
Co-authored-by: petrovicz <10641425+petrovicz@users.noreply.github.com>
Co-authored-by: petrovicz <10641425+petrovicz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Analyzer & Fixer: Detect/replace Geometry.Union in loop with CascadedPolygonUnion.Union (GIS001)
Implement GIS001 analyzer to detect inefficient Geometry.Union calls in loops
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a new Roslyn analyzer (GIS001) that detects performance issues with NetTopologySuite's
Geometry.Unionmethod when called repeatedly inside loops.Problem
Calling
Geometry.Union()repeatedly in loops has poor performance characteristics:This pattern is problematic because:
Solution
The analyzer detects this pattern and provides a code fix that replaces it with
CascadedPolygonUnion.Union():Implementation Details
Analyzer Features
Geometry.Unioncalls insidefor,foreach, andwhileloopsUnioncalls (like LINQEnumerable.Union)Code Fix Provider
CascadedPolygonUnion.Union()callsusing NetTopologySuite.Operation.Union;directiveTesting
Files Changed
Optilizer/GeometryUnionInLoopAnalyzer.cs- Main analyzer implementationOptilizer.CodeFixes/GeometryUnionInLoopCodeFixProvider.cs- Code fix providerOptilizer.Test/GeometryUnionInLoopTests.cs- Comprehensive test suiteREADME.md- Updated documentation with GIS001 details and examplesThe implementation follows all repository conventions and integrates seamlessly with the existing Optilizer analyzer suite.
This pull request was created as a result of the following prompt from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.