policy: raise MAX_STANDARD_TX_WEIGHT toward the consensus limit#19
Open
hans-crypto wants to merge 1 commit intopetertodd:libre-relay-v30.2from
Open
policy: raise MAX_STANDARD_TX_WEIGHT toward the consensus limit#19hans-crypto wants to merge 1 commit intopetertodd:libre-relay-v30.2from
hans-crypto wants to merge 1 commit intopetertodd:libre-relay-v30.2from
Conversation
Raises MAX_STANDARD_TX_WEIGHT from 400000 (100 kvB) to 4000000 (consensus block-weight limit). Lets Libre Relay propagate the class of consensus-valid transactions that miners are already including via out-of-band submission paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
MAX_STANDARD_TX_WEIGHTis 400000 (100 kvB), while a single transaction can in principle reach close to the 4M weight consensus limit (~1000 kvB). Transactions in that range are regularly mined via out-of-band submission, but don't propagate via standard mempool relay.Raising this policy cap toward the consensus limit would let Libre Relay nodes propagate the same class of transactions miners are already including, which seems aligned with the project's goal of removing relay filters that don't reflect what miners accept.
This PR does the minimum-diff version: a single literal change in
src/policy/policy.hfrom400000to4000000. Note one derived consequence —MAX_OP_RETURN_RELAYis defined asMAX_STANDARD_TX_WEIGHT / WITNESS_SCALE_FACTOR, so the default-datacarriersizefloor moves with it (100 kvB → 1000 kvB). Easy to break that link and keep the OP_RETURN default where it is, if preferred — flagging here so the choice is visible.@petertodd, would be curious to hear your thoughts on whether this fits the project's direction. Happy to take feedback or close if not the right shape.
Thanks for considering.