Implement Project Parallelism in IlSpyCmd (Stacked PR #5)

[petercrabtree]

No description provided.

[christophwille]

Given the big file changes - crlf issues or other reformatting going on?

[christophwille]

Note: that then needs an entry in https://github.com/icsharpcode/ILSpy/blob/master/doc/third-party-notices.txt

[petercrabtree]

Added, thanks for catching that.

[Copilot]

Pull Request Overview

This PR implements project parallelism in IlSpyCmd, enabling concurrent decompilation of multiple assemblies with progress tracking and enhanced user experience.

• Adds parallel processing support for decompiling multiple assemblies into a solution using configurable job limits
• Integrates Spectre.Console for rich progress visualization with individual task tracking and overall progress indication
• Improves performance through concurrent execution and optimized garbage collection settings

Reviewed Changes

Copilot reviewed 7 out of 16 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
doc/third-party-notices.txt	Adds MIT license notice for Spectre.Console dependency
ILSpy.sln.DotSettings	Updates ReSharper settings with migration flags
ICSharpCode.ILSpyCmd/packages.lock.json	Locks new package versions for Spectre.Console and System.Threading.Channels
ICSharpCode.ILSpyCmd/IlspyCmdProgram.cs	Main implementation of parallel decompilation with progress tracking
ICSharpCode.ILSpyCmd/ICSharpCode.ILSpyCmd.csproj	Adds package references and enables server GC with adaptation mode
ICSharpCode.Decompiler/Solution/SolutionCreator.cs	Adds exception handling around project reference fixing
Directory.Packages.props	Defines package versions for new dependencies

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The indentation uses tabs instead of spaces, which is inconsistent with the rest of the codebase that uses spaces.

Suggested change

	(or with max of 4 parallel jobs)
	(or with max of 4 parallel jobs)

[Copilot]

Accessing .Value on a nullable double without null checking will throw an exception when value.TotalUnits == 0. The variable should be checked for null before accessing its value.

Suggested change

	double? _fractionDoneNow = value.TotalUnits == 0 ? null : (double)value.UnitsCompleted / value.TotalUnits;
	var fractionDoneNow = _fractionDoneNow.Value;
	double fractionDoneNow = (double)value.UnitsCompleted / value.TotalUnits;

[Copilot]

The tuple parameter with 8 elements is difficult to read and maintain. Consider creating a dedicated struct or class to encapsulate these parameters.

Suggested change

	static async ValueTask DecompileProjectAsync(
	(string name, ProgressTask task, DecompilerSettings settings, string[] referencePaths, (bool IsSet, string Value) inputPDBFile, ConcurrentBag<ProjectItem> projects, string outputDirectory, ProgressTask projectTrackingTask) projectContext,
	CancellationToken token,
	IProgress<DecompilationProgress> progress)
	{
	var (file, progressTask, settings, referencePaths, inputPDBFile, projects, outputDirectory, projectTrackingTask) = projectContext;
	class ProjectContext
	{
	public string Name { get; }
	public ProgressTask Task { get; }
	public DecompilerSettings Settings { get; }
	public string[] ReferencePaths { get; }
	public (bool IsSet, string Value) InputPDBFile { get; }
	public ConcurrentBag<ProjectItem> Projects { get; }
	public string OutputDirectory { get; }
	public ProgressTask ProjectTrackingTask { get; }
	public ProjectContext(
	string name,
	ProgressTask task,
	DecompilerSettings settings,
	string[] referencePaths,
	(bool IsSet, string Value) inputPDBFile,
	ConcurrentBag<ProjectItem> projects,
	string outputDirectory,
	ProgressTask projectTrackingTask)
	{
	Name = name;
	Task = task;
	Settings = settings;
	ReferencePaths = referencePaths;
	InputPDBFile = inputPDBFile;
	Projects = projects;
	OutputDirectory = outputDirectory;
	ProjectTrackingTask = projectTrackingTask;
	}
	}
	static async ValueTask DecompileProjectAsync(
	ProjectContext projectContext,
	CancellationToken token,
	IProgress<DecompilationProgress> progress)
	{
	var file = projectContext.Name;
	var progressTask = projectContext.Task;
	var settings = projectContext.Settings;
	var referencePaths = projectContext.ReferencePaths;
	var inputPDBFile = projectContext.InputPDBFile;
	var projects = projectContext.Projects;
	var outputDirectory = projectContext.OutputDirectory;
	var projectTrackingTask = projectContext.ProjectTrackingTask;

[Copilot]

The progress task is stopped twice - once at line 629 after the parallel loop and again here at line 675. This could cause issues with the progress display.

Suggested change

	progressTask.StopTask(); // remove from the progress display
	// progressTask.StopTask(); // removed: already stopped after the parallel loop

[petercrabtree]

Given the big file changes - crlf issues or other reformatting going on?

Yes, this happens to be one of the roughest parts of using jj for source control, no autocrlf. Apologies for the long delay getting it fixed. You should be able to effectively see the actual changes now. @christophwille

[petercrabtree]

Note that this code is still somewhat rough (e.g. the review comments from copilot); I'm putting it here to give y'all an early peek, and to ensure it'll display correctly when I open a PR upstream.