Conversation
Maintain and use linked list of associations (struct peer) in ntpd, avoiding walking 128 hash table entries to iterate over peers. Remove more workarounds unneeded since we require ISO C90 AKA ANSI C: - remove fallback implementations for memmove(), memset, strstr(). - do not test for atexit() or memcpy(). Collapse a bunch of code duplication in ntpd/ntp_restrict.c added with support for IPv6. Correct some corner case failures in automatically enabling the MRU list if any "restrict ... limited" is in effect, and in disabling MRU maintenance. (ntp_monitor.c, ntp_restrict.c) Reverse the internal sort order of the address restriction lists, but preserve the same behavior. This allows removal of special-case code related to the default restrictions and more straightforward lookups of restrictions for a given address (now, stop on first match). Move ntp_restrict.c MRU doubly-linked list maintenance code into ntp_lists.h macros, allowing more duplicated source excision. Correct Windows port's refclock_open() to return 0 on failure not -1. Correct CHU, dumbclock, and WWVB drivers to check for 0 returned from refclock_open() on failure. Repair ntpdate.c to handle no longer testing HAVE_TIMER_SETTIME. Do not reference peer_node/unpeer_node after freeing when built with --disable-saveconfig and using DNS.
|
Petablox has received your pull request. Another comment will be posted once the analysis is complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.