Node-mysql-native to be deprecated, switching to node-mysql2#57
Open
wshager wants to merge 3 commits intopersvr:masterfrom
Open
Node-mysql-native to be deprecated, switching to node-mysql2#57wshager wants to merge 3 commits intopersvr:masterfrom
wshager wants to merge 3 commits intopersvr:masterfrom
Conversation
Contributor
Author
|
I guess the dependencies should be changed as well. |
Contributor
Author
|
Please note that having DATE fields (as opposed to DATETIME) will give strange behavior, where the field is split into a giant object. Recursive calls are being made and it takes very long to finish. I don't know if the problem is in perstore or mysql2. |
Contributor
Author
|
There remains the problem of retrieving boolean values from mysql. Any ideas? Please... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node-mysql-native will be deprecated soon. I propose to switch to mysql2. Please not that I have removed all original console output, as I'm not sure yet what the messages should be. I figure not all feedback should be considered a db error.