Repository navigation
move page headers into the desktop app's title bar - #225
Merged
Merged
Conversation
…beside back and forward The desktop title bar grows to 2.75rem with the traffic lights centered in it. Each page's title sits after back, forward and the page's + in that bar, and its other actions on the right of it; the web keeps its header. Page titles drop their counts, Chat's title is the agent's name alone, and Chat's New row becomes the header's add button.
…t on a slow runner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the desktop app, the title bar grows to 2.75rem with the traffic lights centered in it, and each page's header moves into it: the title sits after back, forward and the page's + (Add connection, New agent, Add entry, and Chat's new agent), in regular weight, and other actions stay on the right. The web keeps its header below. This gives the desktop window one bar instead of two stacked ones. Page titles drop their counts ("n connected", "n active"), Chat's title is just the agent's name rather than a button into its settings, and Chat's New row in the agent list becomes the header's add button. A hook measures where each header starts so its contents stay clear of the controls wherever its column begins, and tooltips and menus now float above the title bar.
Open workspace in Conductor