Skip to content

Derive analysis root from config path#4

Merged
longlho merged 1 commit into
mainfrom
codex/config-parent-root
May 18, 2026
Merged

Derive analysis root from config path#4
longlho merged 1 commit into
mainfrom
codex/config-parent-root

Conversation

@longlho
Copy link
Copy Markdown
Contributor

@longlho longlho commented May 18, 2026

Summary:

  • Use the parent directory of --config as the analysis root when --directory is omitted.
  • Preserve the logical analysis root instead of canonicalizing it out of runfiles.
  • Apply the same config-parent default through the Node/NAPI wrapper.
  • Add CLI and npm smoke coverage for config-only runs.

Verification:

  • bazel test //crates/codescythe:codescythe_test //crates/codescythe_cli:codescythe_cli_test
  • bazel build //crates/codescythe_cli:codescythe //crates/codescythe_napi:codescythe_napi //packages/codescythe-darwin-arm64:package
  • CODESCYTHE_PACKAGE_DIR=/private/tmp/... CODESCYTHE_NATIVE_PACKAGE_DIR=/private/tmp/... pnpm test:npm
  • Manual CLI fixture: running from /private/tmp with only --config finds the fixture dead code

Note:

  • Local bazel test //... is blocked by an untracked .worktrees/ checkout under this repo, which Bazel descends into. CI should not have that local directory.

@longlho longlho merged commit 7b90470 into main May 18, 2026
1 check passed
@longlho longlho deleted the codex/config-parent-root branch May 18, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant