Conversation
…lated components - Introduced `createColumnResources` boolean option in Trino options, defaulting to false. - Updated `mapTrinoSchemaToPermitResources` to conditionally create column resources based on the new option. - Modified `TrinoComponent` to pass `createColumnResources` prop. - Enhanced `PDPRunComponent` to accept a `tag` prop for specifying the PDP image tag. - Adjusted Docker command in `PDPRunComponent` to use the provided tag. - Updated Trino resource naming for better clarity in the mapping function. - Reduced healthcheck interval in Docker Compose for faster feedback during tests.
omer9564
approved these changes
Nov 4, 2025
…tency - Updated resource keys in tests to use underscores instead of hyphens for consistency. - Enhanced test assertions to include resource type prefixes (e.g., 'Catalog:', 'Schema:', 'Table:') for better readability. - Added `createColumnResources` option in the `mapTrinoSchemaToPermitResources` function call to align with recent changes.
Tabintel
pushed a commit
to Tabintel/permit-cli
that referenced
this pull request
Dec 5, 2025
…lated components (permitio#139) * Add createColumnResources option to Trino configuration and update related components - Introduced `createColumnResources` boolean option in Trino options, defaulting to false. - Updated `mapTrinoSchemaToPermitResources` to conditionally create column resources based on the new option. - Modified `TrinoComponent` to pass `createColumnResources` prop. - Enhanced `PDPRunComponent` to accept a `tag` prop for specifying the PDP image tag. - Adjusted Docker command in `PDPRunComponent` to use the provided tag. - Updated Trino resource naming for better clarity in the mapping function. - Reduced healthcheck interval in Docker Compose for faster feedback during tests. * Fix lint * Refactor Trino resource mapping tests for improved clarity and consistency - Updated resource keys in tests to use underscores instead of hyphens for consistency. - Enhanced test assertions to include resource type prefixes (e.g., 'Catalog:', 'Schema:', 'Table:') for better readability. - Added `createColumnResources` option in the `mapTrinoSchemaToPermitResources` function call to align with recent changes. * Fix lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Type of Change
Checklist
mainwith an appropriate name (e.g.,fix/issue-123,feature/new-command)New Command Details (if applicable)
src/commandsdirectoryAuthProvidercomponentapiKeyargumentAdditional Notes
Screenshots/Recordings