Add LMS app template for fine-grained authorization#132
Open
Tabintel wants to merge 36 commits intopermitio:mainfrom
Open
Add LMS app template for fine-grained authorization#132Tabintel wants to merge 36 commits intopermitio:mainfrom
Tabintel wants to merge 36 commits intopermitio:mainfrom
Conversation
gemanor
requested changes
Jul 28, 2025
Collaborator
gemanor
left a comment
gemanor
left a comment
There was a problem hiding this comment.
Please address the comments and attach screenshot of environment where you imported the policy
source/templates/lms-app/lmsapp.tf
Outdated
| @@ -0,0 +1,189 @@ | |||
| terraform { | |||
Collaborator
There was a problem hiding this comment.
Please move it to the source/template folder, and add the template description to the root readme file
Also, revert the .gitignore
source/templates/lms-app/lmsapp.tf
Outdated
| required_providers { | ||
| permitio = { | ||
| source = "permitio/permit-io" | ||
| version = "~> 0.0.12" |
Collaborator
There was a problem hiding this comment.
Should be same as other templates
Collaborator
|
Hey @Tabintel - can you address the comments and solve the failing build? |
Author
Hi @gemanor, I have addressed the comments. Here is the screenshot |
…remove unused condition set rules
…y and consistency
Signed-off-by: orweis <orweis@gmail.com>
* Adding support for EU region * Tests added * Fix OAuth Login Bug, API Key Validation Bug, Terraform Export Bug, Infinite Loop Bug with policy create simple, Missing Actions Bug * Default roles added for exporter
…lated components (permitio#139) * Add createColumnResources option to Trino configuration and update related components - Introduced `createColumnResources` boolean option in Trino options, defaulting to false. - Updated `mapTrinoSchemaToPermitResources` to conditionally create column resources based on the new option. - Modified `TrinoComponent` to pass `createColumnResources` prop. - Enhanced `PDPRunComponent` to accept a `tag` prop for specifying the PDP image tag. - Adjusted Docker command in `PDPRunComponent` to use the provided tag. - Updated Trino resource naming for better clarity in the mapping function. - Reduced healthcheck interval in Docker Compose for faster feedback during tests. * Fix lint * Refactor Trino resource mapping tests for improved clarity and consistency - Updated resource keys in tests to use underscores instead of hyphens for consistency. - Enhanced test assertions to include resource type prefixes (e.g., 'Catalog:', 'Schema:', 'Table:') for better readability. - Added `createColumnResources` option in the `mapTrinoSchemaToPermitResources` function call to align with recent changes. * Fix lint
Tabintel
force-pushed
the
add-lms-app-template
branch
from
26ce195 to
24384dc
Compare
…d-lms-app-template
…rmit-cli into add-lms-app-template
gemanor
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adds a new Terraform template
lms-appfor a Learning Management System (LMS) with resources (course,enrollment,assignment), roles (student,teacher,teaching_assistant,admin), attributes, relationships, and fine-grained policies (e.g., students can read enrolled courses). Includes aREADME.mdwith usage instructions. The template is designed to work with a Go-based LMS using Appwrite for authentication and data storage, as described in the accompanying article.Type of Change
Checklist
mainwith an appropriate name (e.g.,fix/issue-123,feature/new-command)New Command Details (if applicable)
src/commandsdirectoryAuthProvidercomponentapiKeyargumentAdditional Notes
The
lmsapp.tffile was initially ignored by .gitignore (likely due to a*.tfrule). I usedgit add -fto include it, as Terraform templates are expected insource/templates/(example:blogging-platform.tf). Please advise if there is a preferred approach.Screenshots/Recordings
Here is a screenshot of the
lmsappfolder added to thesource/templatesdirectory