impr: httpsig duplicate component handling on commit/verify #622
+42
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
addressing the hanging TODO comment in the
src/dev_codec_httpsig.erlmodule regarding RFC 9421 section 2.5 wrt enforcing a MUST:the change rejects duplicate entries in committed during signature base creation in
normalize_for_encoding/3(used by both sign + verify) using a non-perf affecting check (ulist then strict equal size check).i added the
duplicate_signature_component_test()andduplicate_signature_component_verify_test()tests, all mod eunit tests pass:my git commits are signed