Fix IBAction methods with named parameters or no parameters marked as unused #1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unused The swiftNameToSelector function was incorrectly converting Swift method names to Objective-C selectors for IBAction methods: - Named first parameter: `colorTapped(sender:)` should produce `colorTappedWithSender:` but was producing `colorTapped:` - No parameters: `confirmTapped()` should produce `confirmTapped` but was producing `confirmTapped:` - Preposition parameters: `click(for:)` should produce `clickFor:` (no "With" prefix) The fix implements the full Swift-to-ObjC selector conversion rules, including handling of prepositions from Swift's PartsOfSpeech.def. Resolves #1049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The swiftNameToSelector function was incorrectly converting Swift method names to Objective-C selectors for IBAction methods:
colorTapped(sender:)should producecolorTappedWithSender:but was producingcolorTapped:confirmTapped()should produceconfirmTappedbut was producingconfirmTapped:click(for:)should produceclickFor:(no "With" prefix)The fix implements the full Swift-to-ObjC selector conversion rules, including handling of prepositions from Swift's PartsOfSpeech.def.
Resolves #1049