inky: fix blend precision, height quirk, and minor cleanups#117
Open
caglar10ur wants to merge 1 commit into
Open
inky: fix blend precision, height quirk, and minor cleanups#117caglar10ur wants to merge 1 commit into
caglar10ur wants to merge 1 commit into
Conversation
Contributor
caglar10ur
commented
May 16, 2026
- Fix color blending truncation in blend(): compute the full weighted sum as float64 before casting to uint8, avoiding double truncation
- Fix UC8159 on IMPRESSION57 incorrectly reporting height as 447; correct it to 448 in DetectOpts
- Add Opts.String() for human-readable option printing
- Refactor update() if/else chain to a switch statement
- Add TestDevImpression_BlendPrecision to cover the blend fix
- Fix color blending truncation in blend(): compute the full weighted
sum as float64 before casting to uint8, avoiding double truncation
- Fix UC8159 on IMPRESSION57 incorrectly reporting height as 447;
correct it to 448 in DetectOpts
- Add Opts.String() for human-readable option printing
- Refactor update() if/else chain to a switch statement
- Add TestDevImpression_BlendPrecision to cover the blend fix
Signed-off-by: Çağlar Onur <caglar@10ur.org>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
=======================================
+ Coverage 52.6% 52.7% +0.1%
=======================================
Files 117 117
Lines 11801 11803 +2
=======================================
+ Hits 6205 6220 +15
+ Misses 5232 5218 -14
- Partials 364 365 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.