Skip to content

⚡ Reserve vector capacity in const_roll_table::init#4

Merged
perim merged 1 commit into
mainfrom
perf/reserve-vector-capacity-9423218886777946562
May 22, 2026
Merged

⚡ Reserve vector capacity in const_roll_table::init#4
perim merged 1 commit into
mainfrom
perf/reserve-vector-capacity-9423218886777946562

Conversation

@perim
Copy link
Copy Markdown
Owner

@perim perim commented May 22, 2026

💡 What: Added w.reserve(size); to const_roll_table::init before the loop.
🎯 Why: To prevent multiple dynamic memory reallocations while adding elements.
📊 Measured Improvement: In a 1M element iteration loop test over 1,000 instantiations, execution time dropped from 19.54s to 18.54s (an improvement of around 1.0s or ~5%).


PR created automatically by Jules for task 9423218886777946562 started by @perim

Adding a pre-allocation vector reservation prevents multiple memory allocations
during vector growth as the vector is populated.

Co-authored-by: perim <436583+perim@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@perim perim merged commit f9bd9d1 into main May 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant