Skip to content

🧪 Add tests for isinr and icosr scaling functions#3

Merged
perim merged 1 commit into
mainfrom
testing-improvement-isinr-icosr-18321200823291128918
May 22, 2026
Merged

🧪 Add tests for isinr and icosr scaling functions#3
perim merged 1 commit into
mainfrom
testing-improvement-isinr-icosr-18321200823291128918

Conversation

@perim
Copy link
Copy Markdown
Owner

@perim perim commented May 22, 2026

🎯 What: The testing gap addressed
This adds test coverage for the isinr and icosr scaling functions defined in direction.h, verifying that they correctly scale the base trigonometric functions relative to distance according to a standard float-based calculation.

📊 Coverage: What scenarios are now tested
The tests calculate results across all 16-bit angle inputs (from 0 to UINT16_MAX) and check for accuracy over a spectrum of distances ranging from 0 to 1,000,000. It asserts that deviations from actual float precision remain within calculated scaled tolerance limits based on known approximations in the integer trigonometric routines.

Result: The improvement in test coverage
The isinr and icosr functions are now fully verified against a comprehensive matrix of angles and distances, assuring they retain correct scaling behavior. All changes were cleanly implemented and integrated into the existing test_direction.cpp suite which passes successfully under CTest.


PR created automatically by Jules for task 18321200823291128918 started by @perim

Co-authored-by: perim <436583+perim@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@perim perim merged commit 9a6a8e9 into main May 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant