⚡ Performance: Optimize vector allocation in filtered_const_roll_table#2
Conversation
…ructor Adding `filtered.reserve(mask.size())` and `indices.reserve(mask.size())` prevents multiple memory allocations when creating a `filtered_const_roll_table`. This resulted in a slight reduction in overall construction time. Co-authored-by: perim <436583+perim@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added capacity reservation for the
filteredandindicesvectors inside thefiltered_const_roll_tableconstructor, sizing them tomask.size().🎯 Why: To avoid multiple intermediate memory allocations during
push_backoperations within the loop. This reduces memory fragmentation and saves CPU cycles that would otherwise be spent on reallocation and element copying.📊 Measured Improvement:
I created a micro-benchmark instantiating
filtered_const_roll_table1,000 times with a vector/mask size of 100,000.PR created automatically by Jules for task 10831340825167954980 started by @perim