Skip to content

Conversation

@kdvalin
Copy link

@kdvalin kdvalin commented Dec 8, 2025

Summary

Adds Amazon Linux 2023 (both x86_64 and aarch64) to the CI pipeline and eventual publishing to packagecloud.

Changes

ci.yml: Add support for different arch's, since previously crun downloads were hardcoded to amd64 arch.
whatami: Detect /etc/amazon-release before defaulting to /etc/os-release

Copy link
Member

@kmcdonell kmcdonell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kdvalin My only real concern here is the change in ci.yml means everytime we run this workflow we're adding 2 more "hosts" for a full build and QA (check -g sanity) run.
If this fails for one of the amazonlinux2023 containers we're in a situation where none of the core developers use or can necessarily fix an issue specific to AmazonLinux.

Is there an option for including all of the other pieces of this PR, but doing your own thing for ci.yml?

If not, I'm happy to let this proceed, on the provisio that if it becomes a problem for the wider PCP project, we'll remove these lines from ci.yml until the issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants