-
-
Notifications
You must be signed in to change notification settings - Fork 258
Add AmazonLinux 2023 to CI Pipleline #2428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Adds Amazon Linux 2023 container platform based off Fedora 43 (which is AL2023's base) to start getting test builds going.
Adds Amazon Linux 2023 detection to whatami, output is AmazonLinux <year> to be consitent with other OS like Arch Linux.
kmcdonell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdvalin My only real concern here is the change in ci.yml means everytime we run this workflow we're adding 2 more "hosts" for a full build and QA (check -g sanity) run.
If this fails for one of the amazonlinux2023 containers we're in a situation where none of the core developers use or can necessarily fix an issue specific to AmazonLinux.
Is there an option for including all of the other pieces of this PR, but doing your own thing for ci.yml?
If not, I'm happy to let this proceed, on the provisio that if it becomes a problem for the wider PCP project, we'll remove these lines from ci.yml until the issue is resolved.
Summary
Adds Amazon Linux 2023 (both x86_64 and aarch64) to the CI pipeline and eventual publishing to packagecloud.
Changes
ci.yml: Add support for different arch's, since previously crun downloads were hardcoded toamd64arch.whatami: Detect/etc/amazon-releasebefore defaulting to/etc/os-release