Skip to content

Use StringBuilder for changelist spec creation #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukaspirkl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use StringBuilder for changelist spec creation #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions p4api.net/Changelist.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;

/// <summary>
/// Specifies type of Change List
Expand Down Expand Up @@ -781,12 +782,12 @@ override public String ToString()
}
}

String filesStr = String.Empty;
StringBuilder filesStringBuilder = new StringBuilder();
if (Files != null&&Pending)
{
foreach (FileSpec file in Files)
{
filesStr += $"\t{file.ToEscapedString()}{Environment.NewLine}";
filesStringBuilder.Append($"\t{file.ToEscapedString()}{Environment.NewLine}");
}
}

Expand Down Expand Up @@ -819,7 +820,7 @@ override public String ToString()
String value = String.Format(ChangelistSpecFormat, ChangeNumbeStr,
FormBase.FormatDateTime(ModifiedDate), ClientId, OwnerName,
statusStr,
restrictedStr, importedStr, identityStr, descStr, jobsStr, streamStr, filesStr);
restrictedStr, importedStr, identityStr, descStr, jobsStr, streamStr, filesStringBuilder.ToString());
return value;
}

Expand Down