Remove unnecessary conditionals in TAP helper file#760
Merged
Conversation
Since we already check for larger than 14 we do not need to check for inverse in the else clause.
jeltz
force-pushed
the
rm-unnecessary-conds
branch
from
1e2d810 to
9feaeda
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #760 +/- ##
==========================================
- Coverage 88.33% 88.18% -0.16%
==========================================
Files 3 3
Lines 1329 1329
Branches 201 201
==========================================
- Hits 1174 1172 -2
- Misses 72 73 +1
- Partials 83 84 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dutow
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we already check for larger than 14 we do not need to check for inverse in the else clause.
PG-0