Make sure to hold the entry lock while resetting#724
Merged
Conversation
jeltz
force-pushed
the
reset-locking
branch
2 times, most recently
from
7b74e73 to
287aadc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
==========================================
- Coverage 88.33% 88.31% -0.03%
==========================================
Files 3 3
Lines 1329 1326 -3
Branches 201 198 -3
==========================================
- Hits 1174 1171 -3
Misses 72 72
Partials 83 83 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
artemgavrilov
approved these changes
Jul 1, 2026
dutow
reviewed
Jul 1, 2026
jeltz
force-pushed
the
reset-locking
branch
2 times, most recently
from
a2fd92e to
22cc4fd
Compare
When we switch buckets we believe we may have to reset hash table entries. if that is actually the case is a bit unclear since we also have code which tries to delete all old entries when switching bucket, but we may at least clean up the code so we do not modify entries in shared memory without holding a lock. While at it we also move the taking and releasing of spin locks to a more sensible location.
dutow
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we switch buckets we believe we may have to reset hash table entries. if that is actually the case is a bit unclear since we also have code which tries to delete all old entries when switching bucket, but we may at least clean up the code so we do not modify entries in shared memory without holding a lock.
While at it we also move the taking and releasing of spin locks to a more sensible location.
PG-0