Skip to content

Attempt at cleaning up getting the next bucket#723

Draft
jeltz wants to merge 1 commit into
percona:mainfrom
jeltz:new-bucket-cleanup
Draft

Attempt at cleaning up getting the next bucket#723
jeltz wants to merge 1 commit into
percona:mainfrom
jeltz:new-bucket-cleanup

Conversation

@jeltz

@jeltz jeltz commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

The code for getting the next bucket was unnecessarily complex and hard to read. But is this suggestion good enough? Maybe we need to do an even bigger rewrite of the bucketing? Especially since the whole mess with two atomics and taking an exclusive lock here is pretty odd and unclear if it is even correct for example if we skip some buckets. Will they get cleared out then?

PG-0

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.09%. Comparing base (479f326) to head (6d86675).

Files with missing lines Patch % Lines
src/pg_stat_monitor.c 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
+ Coverage   87.89%   88.09%   +0.20%     
==========================================
  Files           3        3              
  Lines        1280     1277       -3     
  Branches      202      201       -1     
==========================================
  Hits         1125     1125              
+ Misses         69       67       -2     
+ Partials       86       85       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeltz jeltz force-pushed the new-bucket-cleanup branch 2 times, most recently from 467c78e to 9c7c1cd Compare June 21, 2026 20:36
@jeltz jeltz force-pushed the new-bucket-cleanup branch from 9c7c1cd to 072bc87 Compare June 29, 2026 14:55
The code for getting the next bucket was unnecessarily complex and hard
to read.
@jeltz jeltz force-pushed the new-bucket-cleanup branch from 072bc87 to 6d86675 Compare June 29, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant