Attempt at cleaning up getting the next bucket#723
Draft
jeltz wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #723 +/- ##
==========================================
+ Coverage 87.89% 88.09% +0.20%
==========================================
Files 3 3
Lines 1280 1277 -3
Branches 202 201 -1
==========================================
Hits 1125 1125
+ Misses 69 67 -2
+ Partials 86 85 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
467c78e to
9c7c1cd
Compare
9c7c1cd to
072bc87
Compare
The code for getting the next bucket was unnecessarily complex and hard to read.
072bc87 to
6d86675
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code for getting the next bucket was unnecessarily complex and hard to read. But is this suggestion good enough? Maybe we need to do an even bigger rewrite of the bucketing? Especially since the whole mess with two atomics and taking an exclusive lock here is pretty odd and unclear if it is even correct for example if we skip some buckets. Will they get cleared out then?
PG-0