-
Notifications
You must be signed in to change notification settings - Fork 66
Fix PMM integration CI #608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
=======================================
Coverage 85.33% 85.33%
=======================================
Files 3 3
Lines 1343 1343
Branches 216 216
=======================================
Hits 1146 1146
Misses 93 93
Partials 104 104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
04ea11a to
5c84456
Compare
5c84456 to
c3f3f9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to make this work with PRs from forked repositories aswell. Probably by doing a checkout/build and then feed the artifact to the PMM stuff somehow.
EDIT:
Or we remove the pull_request trigger and deliberately only run this on main.
PMM integration workflow was broken by changes made on PMM QA framwork side. This PR updates the workflow to address these changes.
c3f3f9c to
dd25640
Compare
Description
Fix and rewrite PMM integration CI workflow
Links
Percona-Lab/qa-integration#187