Skip to content

Remove custom Azure issuer handling from JWT verifier configuration #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
louiszhuang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove custom Azure issuer handling from JWT verifier configuration #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/jwk.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,15 +123,6 @@ jwt_verifier configure_verifier_with_jwks(const std::string& issuer, const picoj
const std::string& required_kid) {
std::string expected_issuer = issuer;

if (issuer_is_azure(issuer)) {
// Microsoft flow is tricky
// JWTs contain issuer referring to sts.windows.net, but device flow only
// works correctly with login.microsoftonline.com/v2
// we have to be aware of this and add custom issuer to the verifier
elog(DEBUG1, "Detected Azure issuer, will use custom issuer validation");
expected_issuer = convert_azure_issuer_to_jwt_format(issuer);
}

auto verifier = jwt::verify().with_issuer(expected_issuer);

if (!jwksInfo.is<picojson::object>()) {
Expand Down