Skip to content

Add pg_oidc_validator.enforce_scope GUC to allow disabling scope vali… #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pm-betsys wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add pg_oidc_validator.enforce_scope GUC to allow disabling scope vali… #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/pg_oidc_validator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,15 @@ const OAuthValidatorCallbacks* _PG_oauth_validator_module_init(void) { return &v
}

static char* authn_field = nullptr;
static bool enforce_scope = true;

extern "C" void _PG_init() {
DefineCustomStringVariable("pg_oidc_validator.authn_field",
gettext_noop("OAuth field used for matching PostgreSQL users"), nullptr, &authn_field,
"sub", PGC_SIGHUP, 0, nullptr, nullptr, nullptr);
DefineCustomBoolVariable("pg_oidc_validator.enforce_scope",
gettext_noop("Whether to enforce scope validation against the OAuth token"), nullptr,
&enforce_scope, true, PGC_SIGHUP, 0, nullptr, nullptr, nullptr);
}

bool validate_token(const ValidatorModuleState* state, const char* token, const char* role,
Expand Down Expand Up @@ -109,7 +113,9 @@ bool validate_token(const ValidatorModuleState* state, const char* token, const
}
PG_END_TRY();

if (issuer_is_azure(issuer)) {
if (!enforce_scope) {
res->authorized = true;
} else if (issuer_is_azure(issuer)) {
if (strcmp(authn_field, "sub") == 0) {
elog(WARNING,
"sub field is not guaranteed to be unique with Entra ID, consider using a different field for user "
Expand Down