fix(editor): keep preview heading sync stable#1075
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Stabilizes editor-to-preview scroll synchronization when navigating headings in the Markdown editor preview, particularly for headings whose rendered structure can cause data-line targeting to be unreliable.
Changes:
- Updates preview scroll targeting to prefer heading IDs (slug-based) and improves scroll position calculation/clamping.
- Adds e2e coverage to ensure repeated heading clicks don’t reset preview scroll to the top.
- Minor CSS formatting adjustment for a heading + code block selector.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ui/leafwiki-ui/src/features/preview/markdownPreviewCodeTheme.css | Reflows a complex selector for readability without changing behavior. |
| ui/leafwiki-ui/src/features/editor/MarkdownEditor.tsx | Improves preview scrolling logic, adds heading-ID targeting, and keeps scroll position stable across preview re-renders/resizes. |
| e2e/tests/editor.spec.ts | Adds an e2e regression test covering heading-click preview scroll stability (with a large fixture). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
perber
force-pushed
the
fix/editor-preview-heading-scroll-1061
branch
from
c77cf4f to
58314b5
Compare
Keep smooth scrolling when selecting headings in the markdown editor while re-syncing after preview layout shifts. Add an E2E regression test with a repo-owned markdown fixture that reproduces the preview jump-to-top behavior without relying on externally provided files.
perber
force-pushed
the
fix/editor-preview-heading-scroll-1061
branch
from
58314b5 to
8761319
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.