Skip to content

Conversation

@pepe5p
Copy link
Owner

@pepe5p pepe5p commented Jun 24, 2025

No description provided.

@pepe5p pepe5p requested a review from Copilot June 24, 2025 22:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the project’s packaging from Poetry to a PEP 621/Hatchling + UV-based setup, updates the CI pipeline accordingly, and cleans up an unused import.

  • Swapped tool.poetry metadata for a PEP 621 [project] table and switched build backend to Hatchling.
  • Introduced UV tool commands in the GitHub Actions workflow for dependency sync and test execution.
  • Removed the Union import from test helpers.

Reviewed Changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

File Description
tests/helpers.py Removed unused Union import from typing.
pyproject.toml Replaced Poetry sections with PEP 621 [project], added Hatchling, and configured tool.uv.
.github/workflows/test.yml Replaced poetry install/poetry run with uv sync and uv run pytest.
Comments suppressed due to low confidence (3)

pyproject.toml:11

  • PEP 621 specifies optional dependencies under project.optional-dependencies rather than a top-level [dependency-groups]. Moving your dev dependencies into [project.optional-dependencies] ensures Hatchling and other PEP 621 tools recognize and install them correctly.
[dependency-groups]

pyproject.toml:5

  • PEP 621 metadata usually expects authors as a list of strings (e.g., ["Piotr Karaś <pepe500p@gmail.com>"]). Consider switching to the string form for better compatibility with PyPI and build tools.
authors = [{ name = "Piotr Karaś", email = "pepe500p@gmail.com" }]

.github/workflows/test.yml:28

  • [nitpick] Ensure uv sync installs your development dependencies as intended. If it defaults to only production dependencies, you may need to pass a flag like uv sync --dev or similar to include the dev group.
          uv sync

@pepe5p pepe5p merged commit d70e320 into main Jun 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants