[TEST] Added unit tests for MetadataServiceUtil and MetadataService …

[rcanuto]

…classes

[wingman-pentaho]

Build Completed

🔥 This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.

Build Commands

ant -Dtestreports.dir=bin/reports/unit-test -f build.xml clean-all resolve jacoco && ant -Dtestreports.dir=bin/reports/integration-test -f build.xml jacoco-integration checkstyle

Cleanup Commands

rm -r ~/.ivy2/local || echo no publish local to remove

Changed files

  src/org/pentaho/platform/dataaccess/metadata/service/MetadataServiceUtil.java
  test-src/org/pentaho/platform/dataaccess/metadata/service/MetadataServiceTest.java
  test-src/org/pentaho/platform/dataaccess/metadata/service/MetadataServiceUtilTest.java

Still Broken Tests:

org.pentaho.platform.dataaccess.datasource.DataSourcePublishIT.testDSW_ACL:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: expected:<404> but was:<409>
    at org.pentaho.platform.dataaccess.datasource.DataSourcePublishIT.testDSW_ACL(DataSourcePublishIT.java:572)
    at org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:75)
    at org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:86)
    at org.springframework.test.context.junit4.statements.SpringRep

org.pentaho.platform.dataaccess.datasource.DataSourcePublishIT.testMetadata_ACL:

🔴 junit.framework.AssertionFailedError

junit.framework.AssertionFailedError: expected:<404> but was:<409>
    at org.pentaho.platform.dataaccess.datasource.DataSourcePublishIT.testMetadata_ACL(DataSourcePublishIT.java:445)
    at org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:75)
    at org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:86)
    at org.springframework.test.context.junit4.statements.Spri

org.pentaho.platform.dataaccess.datasource.DataSourcePublishIT.testPublishDSW:

🔴 com.sun.jersey.api.client.ClientHandlerException

com.sun.jersey.api.client.ClientHandlerException: A message body reader for Java class org.pentaho.platform.repository2.unified.webservices.RepositoryFileAclDto, and Java type class org.pentaho.platform.repository2.unified.webservices.RepositoryFileAclDto, and MIME media type text/plain; charset=iso-8859-1 was not found
    at com.sun.jersey.api.client.ClientResponse.getEntity(ClientResponse.java:630)
    at com.sun.jersey.api.client.ClientResponse.getEntity(ClientResponse.java:586)
    at org.pentaho.pl

org.pentaho.platform.dataaccess.datasource.DataSourcePublishIT.testPublishMetadata:

🔴 com.sun.jersey.api.client.ClientHandlerException

com.sun.jersey.api.client.ClientHandlerException: A message body reader for Java class org.pentaho.platform.repository2.unified.webservices.RepositoryFileAclDto, and Java type class org.pentaho.platform.repository2.unified.webservices.RepositoryFileAclDto, and MIME media type text/plain; charset=iso-8859-1 was not found
    at com.sun.jersey.api.client.ClientResponse.getEntity(ClientResponse.java:630)
    at com.sun.jersey.api.client.ClientResponse.getEntity(ClientResponse.java:586)
    at org.pentaho.pl

Unit test coverage change

These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

org.pentaho.platform.dataaccess.metadata.model.impl.Column

• Complexity Change: + 61.90%
• Instruction Change: + 64.29%
• Line Change: + 75.00%
• Method Change: + 61.90%

org.pentaho.platform.dataaccess.metadata.model.impl.Condition

• Complexity Change: + 4.35%
• Instruction Change: + 5.58%
• Line Change: + 10.53%
• Method Change: + 7.14%

org.pentaho.platform.dataaccess.metadata.model.impl.Order

• Complexity Change: + 71.43%
• Instruction Change: + 70.83%
• Line Change: + 70.00%
• Method Change: + 71.43%

org.pentaho.platform.dataaccess.metadata.model.impl.Parameter

• Branch Change: + 50.00%
• Complexity Change: + 41.67%
• Instruction Change: + 45.45%
• Line Change: + 47.37%
• Method Change: + 45.45%

org.pentaho.platform.dataaccess.metadata.model.impl.Query

• Complexity Change: + 76.47%
• Instruction Change: + 80.00%
• Line Change: + 76.67%
• Method Change: + 76.47%

org.pentaho.platform.dataaccess.metadata.service.MetadataService

• Complexity Change: + 2.50%
• Instruction Change: + 4.76%
• Line Change: + 4.65%
• Method Change: + 4.55%

org.pentaho.platform.dataaccess.metadata.service.MetadataServiceUtil

• Branch Change: + 30.88%
• Complexity Change: + 25.00%
• Instruction Change: + 25.63%
• Line Change: + 31.01%
• Method Change: + 21.43%

[buildguy]

❌ Build failed in 30m 20s

Build command:

mvn clean verify -B -e -Daudit -amd

---

❗ No tests found!

Errors:

Filtered log (click to expand)

/build/wingman/workspace/maintenance/wingman/builds/pentaho.data-access.PR-800/pom.xml does not exist.

ℹ️ This is an automatic message