deduplication: ignore periods when comparing names #1718
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small extension to our deduplication logic so that periods in names will be ignored when comparing for dedupication. For example, a query for `3929 St Marks Avenue, Niagara Falls, ON, Canada` returns two duplicate addresses from OpenAddresses. One is sourced from a countrywide dataset, and another a regional dataset. One has a period after the abbreviation for Saint, one doesn't. We should probably evaluate ignoring most or all punctuation, but this fixes a somewhat common case for now.
orangejulius
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small extension to our deduplication logic so that periods in names will be ignored when comparing for dedupication.
For example, a query for
3929 St Marks Avenue, Niagara Falls, ON, Canadareturns two duplicate addresses from OpenAddresses. One is sourced from a countrywide dataset, and another a regional dataset. One has a period after the abbreviation for Saint, one doesn't.We should probably evaluate ignoring most or all punctuation, but this fixes a somewhat common case for now.